diff options
| author | Mara Bos <m-ou.se@m-ou.se> | 2021-02-04 21:10:36 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-04 21:10:36 +0100 |
| commit | 87b269ab6654ddcaed43933ebcd3754d000117b7 (patch) | |
| tree | 97f1329a2518b204ea50c667272fb2db77f872a8 /compiler/rustc_errors | |
| parent | c5990dd8ad83fa1dccbc105102bceca0728977c3 (diff) | |
| parent | 0870c154b63319df131de822d85dcebcbba080af (diff) | |
| download | rust-87b269ab6654ddcaed43933ebcd3754d000117b7.tar.gz rust-87b269ab6654ddcaed43933ebcd3754d000117b7.zip | |
Rollup merge of #81645 - m-ou-se:panic-lint, r=estebank,flip1995
Add lint for `panic!(123)` which is not accepted in Rust 2021.
This extends the `panic_fmt` lint to warn for all cases where the first argument cannot be interpreted as a format string, as will happen in Rust 2021.
It suggests to add `"{}",` to format the message as a string. In the case of `std::panic!()`, it also suggests the recently stabilized
`std::panic::panic_any()` function as an alternative.
It renames the lint to `non_fmt_panic` to match the lint naming guidelines.
This is part of #80162.
r? ```@estebank```
Diffstat (limited to 'compiler/rustc_errors')
| -rw-r--r-- | compiler/rustc_errors/src/lib.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/compiler/rustc_errors/src/lib.rs b/compiler/rustc_errors/src/lib.rs index e184e929b07..aa882332099 100644 --- a/compiler/rustc_errors/src/lib.rs +++ b/compiler/rustc_errors/src/lib.rs @@ -901,7 +901,7 @@ impl HandlerInner { fn span_bug(&mut self, sp: impl Into<MultiSpan>, msg: &str) -> ! { self.emit_diag_at_span(Diagnostic::new(Bug, msg), sp); - panic!(ExplicitBug); + panic::panic_any(ExplicitBug); } fn emit_diag_at_span(&mut self, mut diag: Diagnostic, sp: impl Into<MultiSpan>) { @@ -955,7 +955,7 @@ impl HandlerInner { fn bug(&mut self, msg: &str) -> ! { self.emit_diagnostic(&Diagnostic::new(Bug, msg)); - panic!(ExplicitBug); + panic::panic_any(ExplicitBug); } fn delay_as_bug(&mut self, diagnostic: Diagnostic) { |