diff options
| author | bors <bors@rust-lang.org> | 2024-05-15 14:52:49 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-05-15 14:52:49 +0000 |
| commit | b21b74b5e673b9102502e8f69f378313d901746c (patch) | |
| tree | 777b3ce01d69091a6bf23092ddcdc23995019e1f /compiler/rustc_errors | |
| parent | ade234d5743795423db6cc7cd52541390a088eab (diff) | |
| parent | 8994840f7e61c1e90db35e7d966d0271880d905c (diff) | |
| download | rust-b21b74b5e673b9102502e8f69f378313d901746c.tar.gz rust-b21b74b5e673b9102502e8f69f378313d901746c.zip | |
Auto merge of #125134 - compiler-errors:negative-traits-are-not-notable, r=fmease
rustdoc: Negative impls are not notable In #124097, we add `impl !Iterator for [T]` for coherence reasons, and since `Iterator` is a [notable trait](https://github.com/rust-lang/rust/blob/8387315ab3c26a57a1f53a90f188f0bc88514bca/library/core/src/iter/traits/iterator.rs#L40), this means that all `-> &[_]` now are tagged with a `!Iterator` impl as a notable trait. I "fixed" the failing tests in that PR with 6cbbb8b709a43482847243484ed67131e372ba71, where I just blessed the tests, since I didn't want to mix these changes with that PR; however, don't believe negative impls are notable, and this PR aims to prevent these impls from being mentioned. In the standard library, we use negative impls purely to guide coherence. They're not really a signal of anything useful to the end-user. If there ever is a case that we want negative impls to be mentioned as notable, this really should be an opt-in feature.
Diffstat (limited to 'compiler/rustc_errors')
0 files changed, 0 insertions, 0 deletions