diff options
| author | bors <bors@rust-lang.org> | 2021-08-03 04:50:28 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2021-08-03 04:50:28 +0000 |
| commit | e91405b9d5c8dabb3e488bafb314147f1050f9b9 (patch) | |
| tree | e685ca7d120d1d9e26e06a1c4a64142c9f9da488 /compiler/rustc_expand/src | |
| parent | 810b9267f38a398c28dd213bad4acc58dce0199a (diff) | |
| parent | 55ff45a5c25c49e665a9459b8d6ea03ae2c44476 (diff) | |
Auto merge of #87262 - dtolnay:negative, r=Aaron1011
Support negative numbers in Literal::from_str proc_macro::Literal has allowed negative numbers in a single literal token ever since Rust 1.29, using https://doc.rust-lang.org/stable/proc_macro/struct.Literal.html#method.isize_unsuffixed and similar constructors. ```rust let lit = proc_macro::Literal::isize_unsuffixed(-10); ``` However, the suite of constructors on Literal is not sufficient for all use cases, for example arbitrary precision floats, or custom suffixes in FFI macros. ```rust let lit = proc_macro::Literal::f64_unsuffixed(0.101001000100001000001000000100000001); // :( let lit = proc_macro::Literal::i???_suffixed(10ulong); // :( ``` For those, macros construct the literal using from_str instead, which preserves arbitrary precision, custom suffixes, base, and digit grouping. ```rust let lit = "0.101001000100001000001000000100000001".parse::<Literal>().unwrap(); let lit = "10ulong".parse::<Literal>().unwrap(); let lit = "0b1000_0100_0010_0001".parse::<Literal>().unwrap(); ``` However, until this PR it was not possible to construct a literal token that is **both** negative **and** preserving of arbitrary precision etc. This PR fixes `Literal::from_str` to recognize negative integer and float literals.
Diffstat (limited to 'compiler/rustc_expand/src')
| -rw-r--r-- | compiler/rustc_expand/src/proc_macro_server.rs | 63 |
1 files changed, 41 insertions, 22 deletions
diff --git a/compiler/rustc_expand/src/proc_macro_server.rs b/compiler/rustc_expand/src/proc_macro_server.rs index b949d885900..47cc2ecb4bf 100644 --- a/compiler/rustc_expand/src/proc_macro_server.rs +++ b/compiler/rustc_expand/src/proc_macro_server.rs @@ -1,7 +1,7 @@ use crate::base::{ExtCtxt, ResolverExpand}; use rustc_ast as ast; -use rustc_ast::token::{self, Nonterminal, NtIdent, TokenKind}; +use rustc_ast::token::{self, Nonterminal, NtIdent}; use rustc_ast::tokenstream::{self, CanSynthesizeMissingTokens}; use rustc_ast::tokenstream::{DelimSpan, Spacing::*, TokenStream, TreeAndSpacing}; use rustc_ast_pretty::pprust; @@ -537,30 +537,49 @@ impl server::Ident for Rustc<'_> { impl server::Literal for Rustc<'_> { fn from_str(&mut self, s: &str) -> Result<Self::Literal, ()> { - let override_span = None; - let stream = parse_stream_from_source_str( - FileName::proc_macro_source_code(s), - s.to_owned(), - self.sess, - override_span, - ); - if stream.len() != 1 { - return Err(()); - } - let tree = stream.into_trees().next().unwrap(); - let token = match tree { - tokenstream::TokenTree::Token(token) => token, - tokenstream::TokenTree::Delimited { .. } => return Err(()), + let name = FileName::proc_macro_source_code(s); + let mut parser = rustc_parse::new_parser_from_source_str(self.sess, name, s.to_owned()); + + let first_span = parser.token.span.data(); + let minus_present = parser.eat(&token::BinOp(token::Minus)); + + let lit_span = parser.token.span.data(); + let mut lit = match parser.token.kind { + token::Literal(lit) => lit, + _ => return Err(()), }; - let span_data = token.span.data(); - if (span_data.hi.0 - span_data.lo.0) as usize != s.len() { - // There is a comment or whitespace adjacent to the literal. + + // Check no comment or whitespace surrounding the (possibly negative) + // literal, or more tokens after it. + if (lit_span.hi.0 - first_span.lo.0) as usize != s.len() { return Err(()); } - let lit = match token.kind { - TokenKind::Literal(lit) => lit, - _ => return Err(()), - }; + + if minus_present { + // If minus is present, check no comment or whitespace in between it + // and the literal token. + if first_span.hi.0 != lit_span.lo.0 { + return Err(()); + } + + // Check literal is a kind we allow to be negated in a proc macro token. + match lit.kind { + token::LitKind::Bool + | token::LitKind::Byte + | token::LitKind::Char + | token::LitKind::Str + | token::LitKind::StrRaw(_) + | token::LitKind::ByteStr + | token::LitKind::ByteStrRaw(_) + | token::LitKind::Err => return Err(()), + token::LitKind::Integer | token::LitKind::Float => {} + } + + // Synthesize a new symbol that includes the minus sign. + let symbol = Symbol::intern(&s[..1 + lit.symbol.len()]); + lit = token::Lit::new(lit.kind, symbol, lit.suffix); + } + Ok(Literal { lit, span: self.call_site }) } fn debug_kind(&mut self, literal: &Self::Literal) -> String { |
