about summary refs log tree commit diff
path: root/compiler/rustc_hir_analysis/src/check/check.rs
diff options
context:
space:
mode:
authorJubilee Young <workingjubilee@gmail.com>2025-06-12 09:56:29 -0700
committerJubilee Young <workingjubilee@gmail.com>2025-06-23 09:40:00 -0700
commit267ecd132bbafc2651bfa69cd8bdb958d677132b (patch)
tree8716da1b22b227f0938936f023a6cf3d0ffe48ec /compiler/rustc_hir_analysis/src/check/check.rs
parentb34c52043f8df344b32789e0a4b26fd0f9965643 (diff)
downloadrust-267ecd132bbafc2651bfa69cd8bdb958d677132b.tar.gz
rust-267ecd132bbafc2651bfa69cd8bdb958d677132b.zip
Clarify note in rustc_ast_lowering still applies
Co-authored-by: Ralf Jung <post@ralfj.de>
Diffstat (limited to 'compiler/rustc_hir_analysis/src/check/check.rs')
-rw-r--r--compiler/rustc_hir_analysis/src/check/check.rs5
1 files changed, 3 insertions, 2 deletions
diff --git a/compiler/rustc_hir_analysis/src/check/check.rs b/compiler/rustc_hir_analysis/src/check/check.rs
index 40e08dcdb55..0bdccb02a71 100644
--- a/compiler/rustc_hir_analysis/src/check/check.rs
+++ b/compiler/rustc_hir_analysis/src/check/check.rs
@@ -52,8 +52,9 @@ fn add_abi_diag_help<T: EmissionGuarantee>(abi: ExternAbi, diag: &mut Diag<'_, T
 }
 
 pub fn check_abi(tcx: TyCtxt<'_>, hir_id: hir::HirId, span: Span, abi: ExternAbi) {
-    // FIXME: this should be checked earlier, e.g. in `rustc_ast_lowering`, to fix
-    // things like #86232.
+    // FIXME: This should be checked earlier, e.g. in `rustc_ast_lowering`, as this
+    // currently only guards function imports, function definitions, and function pointer types.
+    // Functions in trait declarations can still use "deprecated" ABIs without any warning.
 
     match AbiMap::from_target(&tcx.sess.target).canonize_abi(abi, false) {
         AbiMapping::Direct(..) => (),