diff options
| author | Michael Goulet <michael@errs.io> | 2023-03-08 00:00:02 +0000 |
|---|---|---|
| committer | Michael Goulet <michael@errs.io> | 2023-03-08 00:00:19 +0000 |
| commit | 0f4255ece2e2ff5e0ab7467513cd45d3cdecb27d (patch) | |
| tree | 062e3c51f6a746943aa731d144600da0b33c2623 /compiler/rustc_hir_analysis/src/coherence/builtin.rs | |
| parent | a439c0293cc7aa31d89f76abfe03eb5fdeebde1a (diff) | |
| download | rust-0f4255ece2e2ff5e0ab7467513cd45d3cdecb27d.tar.gz rust-0f4255ece2e2ff5e0ab7467513cd45d3cdecb27d.zip | |
Dedup copy field errors for identical types
Diffstat (limited to 'compiler/rustc_hir_analysis/src/coherence/builtin.rs')
| -rw-r--r-- | compiler/rustc_hir_analysis/src/coherence/builtin.rs | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/compiler/rustc_hir_analysis/src/coherence/builtin.rs b/compiler/rustc_hir_analysis/src/coherence/builtin.rs index 852c5768399..8294d92c936 100644 --- a/compiler/rustc_hir_analysis/src/coherence/builtin.rs +++ b/compiler/rustc_hir_analysis/src/coherence/builtin.rs @@ -2,6 +2,7 @@ //! up data structures required by type-checking/codegen. use crate::errors::{CopyImplOnNonAdt, CopyImplOnTypeWithDtor, DropImplOnWrongItem}; +use rustc_data_structures::fx::FxHashSet; use rustc_errors::{struct_span_err, MultiSpan}; use rustc_hir as hir; use rustc_hir::def_id::{DefId, LocalDefId}; @@ -94,7 +95,14 @@ fn visit_implementation_of_copy(tcx: TyCtxt<'_>, impl_did: LocalDefId) { let mut errors: BTreeMap<_, Vec<_>> = Default::default(); let mut bounds = vec![]; + let mut seen_tys = FxHashSet::default(); + for (field, ty, reason) in fields { + // Only report an error once per type. + if !seen_tys.insert(ty) { + continue; + } + let field_span = tcx.def_span(field.did); err.span_label(field_span, "this field does not implement `Copy`"); |
