about summary refs log tree commit diff
path: root/compiler/rustc_hir_analysis/src/lib.rs
diff options
context:
space:
mode:
authorOli Scherer <git-spam-no-reply9815368754983@oli-obk.de>2023-10-31 13:45:26 +0000
committerOli Scherer <git-spam-no-reply9815368754983@oli-obk.de>2024-01-09 21:08:16 +0000
commit0978f6e010e0eb3dddfa2a1a374ae5567e1f7f4c (patch)
tree088de30be238d47fcc5889f5e5eae9298366e92b /compiler/rustc_hir_analysis/src/lib.rs
parentbe00c5a9b89161b7f45ba80340f709e8e41122f9 (diff)
downloadrust-0978f6e010e0eb3dddfa2a1a374ae5567e1f7f4c.tar.gz
rust-0978f6e010e0eb3dddfa2a1a374ae5567e1f7f4c.zip
Avoid silencing relevant follow-up errors
Diffstat (limited to 'compiler/rustc_hir_analysis/src/lib.rs')
-rw-r--r--compiler/rustc_hir_analysis/src/lib.rs11
1 files changed, 5 insertions, 6 deletions
diff --git a/compiler/rustc_hir_analysis/src/lib.rs b/compiler/rustc_hir_analysis/src/lib.rs
index b9e7500c894..dfc54ac5b23 100644
--- a/compiler/rustc_hir_analysis/src/lib.rs
+++ b/compiler/rustc_hir_analysis/src/lib.rs
@@ -166,13 +166,12 @@ pub fn check_crate(tcx: TyCtxt<'_>) -> Result<(), ErrorGuaranteed> {
 
     // this ensures that later parts of type checking can assume that items
     // have valid types and not error
-    // FIXME(matthewjasper) We shouldn't need to use `track_errors`.
-    tcx.sess.track_errors(|| {
-        tcx.sess.time("type_collecting", || {
-            tcx.hir().for_each_module(|module| tcx.ensure().collect_mod_item_types(module))
-        });
-    })?;
+    tcx.sess.time("type_collecting", || {
+        tcx.hir().for_each_module(|module| tcx.ensure().collect_mod_item_types(module))
+    });
 
+    // FIXME(matthewjasper) We shouldn't need to use `track_errors` anywhere in this function
+    // or the compiler in general.
     if tcx.features().rustc_attrs {
         tcx.sess.track_errors(|| {
             tcx.sess.time("outlives_testing", || outlives::test::test_inferred_outlives(tcx));