diff options
| author | bors <bors@rust-lang.org> | 2023-12-07 17:28:41 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-12-07 17:28:41 +0000 |
| commit | 49dd3804c0f61cee06abbca3dfb2df7b3a78bee6 (patch) | |
| tree | c11be54a706c68da7d9197ae136332f06295bd9b /compiler/rustc_interface/src/errors.rs | |
| parent | 9975650b3e834818ffc9a0e653391c5a64f9f9fe (diff) | |
| parent | 05e8b926e639a13451e89fae1d9883d1afbec517 (diff) | |
| download | rust-49dd3804c0f61cee06abbca3dfb2df7b3a78bee6.tar.gz rust-49dd3804c0f61cee06abbca3dfb2df7b3a78bee6.zip | |
Auto merge of #16009 - werifu:fix-extract-function, r=Veykril
fix: bug in extract_function.rs There is a little bug in extract_function: It appends `use path::to::ControlFlow;` if the function created contains string "ControlFlow". A case below (also in the test named `does_not_import_control_flow` which will fail in the original code) <img width="322" alt="image" src="https://github.com/rust-lang/rust-analyzer/assets/53432474/4b80bb58-0cfd-4d56-b64c-d9649eed336e"> <img width="391" alt="image" src="https://github.com/rust-lang/rust-analyzer/assets/53432474/3d7262f4-8a4c-44ea-822d-304b8b23fe28"> Now I have changed the condition determining whether adding import statement. Only when the new function body contains ControlFlow::Break or ControlFlow::Continue can the import statement be added. Last related PR: https://github.com/rust-lang/rust-analyzer/pull/10309
Diffstat (limited to 'compiler/rustc_interface/src/errors.rs')
0 files changed, 0 insertions, 0 deletions