about summary refs log tree commit diff
path: root/compiler/rustc_interface/src/passes.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-09-25 11:01:13 +0000
committerbors <bors@rust-lang.org>2021-09-25 11:01:13 +0000
commite9f29a851917a706c01b6f51331894df1d15770b (patch)
treead20f5095b566e7ac8f95f4befb6e6a019eec304 /compiler/rustc_interface/src/passes.rs
parent218a96cae06ed1a47549a81c09c3655fbcae1363 (diff)
parentab64580977ca6dabc07f5944898435708bfbb0c8 (diff)
downloadrust-e9f29a851917a706c01b6f51331894df1d15770b.tar.gz
rust-e9f29a851917a706c01b6f51331894df1d15770b.zip
Auto merge of #89030 - nbdd0121:box2, r=jonas-schievink
Introduce `Rvalue::ShallowInitBox`

Polished version of #88700.

Implements MCP rust-lang/compiler-team#460, and should allow #43596 to go forward.

In short, creating an empty box is split from a nullary-op `NullOp::Box` into two steps, first a call to `exchange_malloc`, then a `Rvalue::ShallowInitBox` which transmutes `*mut u8` to a shallow-initialized `Box<T>`. This allows the `exchange_malloc` call to unwind. Details can be found in the MCP.

`NullOp::Box` is not yet removed, purely to make reverting easier in case anything goes wrong as the result of this PR. If revert is needed a reversion of "Use Rvalue::ShallowInitBox for box expression" commit followed by a test bless should be sufficient.

Experiments in #88700 showed a very slight compile-time perf regression due to (supposedly) slightly more time spent in LLVM. We could omit unwind edge generation (in non-`oom=panic` case) in box expression MIR construction to restore perf; but I don't think it's necessary since runtime perf isn't affected and perf difference is rather small.
Diffstat (limited to 'compiler/rustc_interface/src/passes.rs')
0 files changed, 0 insertions, 0 deletions