about summary refs log tree commit diff
path: root/compiler/rustc_interface/src
diff options
context:
space:
mode:
authorDylan DPC <99973273+Dylan-DPC@users.noreply.github.com>2022-11-12 12:02:53 +0530
committerGitHub <noreply@github.com>2022-11-12 12:02:53 +0530
commit28af6cae9c460b56e203868ef8cfa21c7b8eb444 (patch)
treeec3a73d1c65b66b82da02d9179ec347631294bb1 /compiler/rustc_interface/src
parent35816ff52a0fa21f678373fcb279412e78784fbf (diff)
parent269dad27f23e85359afee82f8fbd144fec616dc9 (diff)
downloadrust-28af6cae9c460b56e203868ef8cfa21c7b8eb444.tar.gz
rust-28af6cae9c460b56e203868ef8cfa21c7b8eb444.zip
Rollup merge of #104267 - notriddle:notriddle/checkbox, r=GuillaumeGomez
rustdoc: use checkbox instead of switch for settings toggles

Preview: http://notriddle.com/notriddle-rustdoc-demos/checkbox/test_dingus/index.html

## Before

![image](https://user-images.githubusercontent.com/1593513/201232887-dee27ef5-b091-49bb-be4a-103d2e7983f3.png)

## After

![image](https://user-images.githubusercontent.com/1593513/201232835-95b40b77-6535-4280-8719-44c992a07772.png)

## Description

The switch ("slider") is designed to give the application a "physical" feel, but nothing else in here really followed through. They didn't support the "flick" gesture that real iOS switches support, and the radio buttons that were also used in Rustdoc Settings were a more "classic" form element anyway.

Also, while switches are the exclusive toggle design on iOS (since [Apple HIG] reserves checkboxes for Mac only), the [Google Material] guidelines say that lists of switches are bad, and you should just use check boxes.

[Apple HIG]: https://developer.apple.com/design/human-interface-guidelines/components/selection-and-input/toggles
[Google Material]: https://m3.material.io/components/checkbox/guidelines#6902f23d-ceba-4b19-ae3b-b78b9b01d185
Diffstat (limited to 'compiler/rustc_interface/src')
0 files changed, 0 insertions, 0 deletions