about summary refs log tree commit diff
path: root/compiler/rustc_interface/src
diff options
context:
space:
mode:
authorYuki Okushi <jtitor@2k36.org>2022-06-22 07:04:04 +0900
committerGitHub <noreply@github.com>2022-06-22 07:04:04 +0900
commitb887da1cb27ef90c9c54c5a9d005e3be3d866dc8 (patch)
treeef26cdacf86d5ccec719961d284ac73dc0024103 /compiler/rustc_interface/src
parent880ac7c51e564033220457d32e8d85c71d3de086 (diff)
parent67508f3714296ffb0cf9820e1c1ba46b082227a3 (diff)
downloadrust-b887da1cb27ef90c9c54c5a9d005e3be3d866dc8.tar.gz
rust-b887da1cb27ef90c9c54c5a9d005e3be3d866dc8.zip
Rollup merge of #98336 - fmease:remove-faulty-doc-hidden-lint, r=GuillaumeGomez
Remove the unused-`#[doc(hidden)]` logic from the `unused_attributes` lint

Fixes #96890.

It was found out that `#[doc(hidden)]` on trait impl items does indeed have an effect on the generated documentation (see the linked issue). In my opinion and the one of [others](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Validy.20checks.20for.20.60.23.5Bdoc.28hidden.29.5D.60/near/281846219), rustdoc's output is actually a bit flawed in that regard but that should be tracked in a new issue I suppose (I will open an issue for that in the near future).

The check was introduced in #96008 which is marked to be part of version `1.62` (current `beta`). As far as I understand, this means that **this PR needs to be backported** to `beta` to fix #96890 on time. Correct me if I am wrong.

CC `@dtolnay` (in case you would like to agree or disagree with my decision to fully remove this check)

`@rustbot` label A-lint T-compiler T-rustdoc

r? `@rust-lang/compiler`
Diffstat (limited to 'compiler/rustc_interface/src')
0 files changed, 0 insertions, 0 deletions