diff options
| author | bors <bors@rust-lang.org> | 2020-11-26 22:02:45 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-11-26 22:02:45 +0000 |
| commit | cb56a4420c8d41aab5c569c0fb6e51098d3a4745 (patch) | |
| tree | 0bba85a4b12f9eef50d07fb15f6176afc779ae21 /compiler/rustc_interface/src | |
| parent | 72da5a9d85a522b11e80d0fdd1fd95247d442604 (diff) | |
| parent | 6e466efa11dc7c8cb4425a6f6a256aaaf8edd6be (diff) | |
| download | rust-cb56a4420c8d41aab5c569c0fb6e51098d3a4745.tar.gz rust-cb56a4420c8d41aab5c569c0fb6e51098d3a4745.zip | |
Auto merge of #79338 - Aaron1011:fix/token-reparse-cache, r=petrochenkov
Cache pretty-print/retokenize result to avoid compile time blowup Fixes #79242 If a `macro_rules!` recursively builds up a nested nonterminal (passing it to a proc-macro at each step), we will end up repeatedly pretty-printing/retokenizing the same nonterminals. Unfortunately, the 'probable equality' check we do has a non-trivial cost, which leads to a blowup in compilation time. As a workaround, we cache the result of the 'probable equality' check, which eliminates the compilation time blowup for the linked issue. This commit only touches a single file (other than adding tests), so it should be easy to backport. The proper solution is to remove the pretty-print/retokenize hack entirely. However, this will almost certainly break a large number of crates that were relying on hygiene bugs created by using the reparsed `TokenStream`. As a result, we will definitely not want to backport such a change.
Diffstat (limited to 'compiler/rustc_interface/src')
0 files changed, 0 insertions, 0 deletions
