diff options
| author | bors <bors@rust-lang.org> | 2021-06-30 05:02:01 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2021-06-30 05:02:01 +0000 |
| commit | 51fd129ac12d5bfeca7d216c47b0e337bf13e0c2 (patch) | |
| tree | a8cfa383dff35085dbf71e48d61198b2223ae912 /compiler/rustc_lint/src | |
| parent | 9af4bdeab0d971d61ea59a02923944fc80daafcc (diff) | |
| parent | f0d7280ff3b608f56031c63930dee0358f8b5038 (diff) | |
Auto merge of #86689 - rylev:future-compat-lint-group, r=nikomatsakis
Only include lint in future_incompatible lint group if not an edition lint A follow up to #86330 - this only includes lints annotated with `FutureIncompatibleInfo` in the `future_incompatibile` lint group if the future compatibility is not tied to an edition. We probably want to rename `FutureIncompatibleInfo` to something else since this type is now used to indicate future breakages of all kinds (even those that happen in editions). I'd prefer to do that in a separate PR though. r? `@nikomatsakis`
Diffstat (limited to 'compiler/rustc_lint/src')
| -rw-r--r-- | compiler/rustc_lint/src/context.rs | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/compiler/rustc_lint/src/context.rs b/compiler/rustc_lint/src/context.rs index 00869ac3c9a..b352b8c31ec 100644 --- a/compiler/rustc_lint/src/context.rs +++ b/compiler/rustc_lint/src/context.rs @@ -220,17 +220,20 @@ impl LintStore { }) .lint_ids .push(id); + } else { + // Lints belonging to the `future_incompatible` lint group are lints where a + // future version of rustc will cause existing code to stop compiling. + // Lints tied to an edition don't count because they are opt-in. + self.lint_groups + .entry("future_incompatible") + .or_insert(LintGroup { + lint_ids: vec![], + from_plugin: lint.is_plugin, + depr: None, + }) + .lint_ids + .push(id); } - - self.lint_groups - .entry("future_incompatible") - .or_insert(LintGroup { - lint_ids: vec![], - from_plugin: lint.is_plugin, - depr: None, - }) - .lint_ids - .push(id); } } } |
