diff options
| author | Nicholas Nethercote <n.nethercote@gmail.com> | 2022-12-07 14:18:19 +1100 |
|---|---|---|
| committer | Nicholas Nethercote <n.nethercote@gmail.com> | 2022-12-07 19:29:31 +1100 |
| commit | ac1e69c9033a33e374f1dd91b3e4cd54e1c0033f (patch) | |
| tree | 69a1c73beb90ff62ea92a22791e635fa15356b91 /compiler/rustc_lint | |
| parent | 0c844730d3f7f7d5d3f01a35b67fa5814ee208ee (diff) | |
| download | rust-ac1e69c9033a33e374f1dd91b3e4cd54e1c0033f.tar.gz rust-ac1e69c9033a33e374f1dd91b3e4cd54e1c0033f.zip | |
Add some useful comments.
Diffstat (limited to 'compiler/rustc_lint')
| -rw-r--r-- | compiler/rustc_lint/src/lib.rs | 9 | ||||
| -rw-r--r-- | compiler/rustc_lint/src/passes.rs | 4 |
2 files changed, 12 insertions, 1 deletions
diff --git a/compiler/rustc_lint/src/lib.rs b/compiler/rustc_lint/src/lib.rs index daf9dbe2abf..1990a74841b 100644 --- a/compiler/rustc_lint/src/lib.rs +++ b/compiler/rustc_lint/src/lib.rs @@ -127,6 +127,7 @@ fn lint_mod(tcx: TyCtxt<'_>, module_def_id: LocalDefId) { late::late_lint_mod(tcx, module_def_id, BuiltinCombinedModuleLateLintPass::new()); } +// See the comment on `BuiltinCombinedEarlyLintPass`, which is similar. early_lint_methods!( declare_combined_early_lint_pass, [ @@ -137,6 +138,9 @@ early_lint_methods!( ] ); +// Declare `BuiltinCombinedEarlyLintPass`, a lint pass that combines multiple +// lint passes into a single pass for maximum speed. Each `check_foo` method +// within this pass simply calls `check_foo` once per listed lint. early_lint_methods!( declare_combined_early_lint_pass, [ @@ -162,7 +166,9 @@ early_lint_methods!( ] ); -// FIXME: Make a separate lint type which do not require typeck tables +// FIXME: Make a separate lint type which does not require typeck tables. + +// See the comment on `BuiltinCombinedEarlyLintPass`, which is similar. late_lint_methods!( declare_combined_late_lint_pass, [ @@ -182,6 +188,7 @@ late_lint_methods!( ] ); +// See the comment on `BuiltinCombinedEarlyLintPass`, which is similar. late_lint_methods!( declare_combined_late_lint_pass, [ diff --git a/compiler/rustc_lint/src/passes.rs b/compiler/rustc_lint/src/passes.rs index c423765b644..312dbcd68bd 100644 --- a/compiler/rustc_lint/src/passes.rs +++ b/compiler/rustc_lint/src/passes.rs @@ -73,6 +73,8 @@ macro_rules! declare_late_lint_pass { ) } +// Declare the `LateLintPass` trait, which contains empty default definitions +// for all the `check_*` methods. late_lint_methods!(declare_late_lint_pass, []); impl LateLintPass<'_> for HardwiredLints {} @@ -176,6 +178,8 @@ macro_rules! declare_early_lint_pass { ) } +// Declare the `EarlyLintPass` trait, which contains empty default definitions +// for all the `check_*` methods. early_lint_methods!(declare_early_lint_pass, []); #[macro_export] |
