diff options
| author | Nilstrieb <48135649+Nilstrieb@users.noreply.github.com> | 2024-02-20 07:35:46 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-20 07:35:46 +0100 |
| commit | 328a5b7719969f21841bc5fe6c87b1bcab7838c9 (patch) | |
| tree | b5e69eafcb812653a108e5b62139cc4937014bc1 /compiler/rustc_llvm/llvm-wrapper/ArchiveWrapper.cpp | |
| parent | 4c2af7877859798eaf7d1e8755eb999627ef6a5c (diff) | |
| parent | e72e7e9ae3a6938f1a926ca10f693d89948134cb (diff) | |
| download | rust-328a5b7719969f21841bc5fe6c87b1bcab7838c9.tar.gz rust-328a5b7719969f21841bc5fe6c87b1bcab7838c9.zip | |
Rollup merge of #121205 - nnethercote:fix-stable-mir-CompilerError, r=oli-obk
Merge `CompilerError::CompilationFailed` and `CompilerError::ICE`.
`CompilerError` has `CompilationFailed` and `ICE` variants, which seems reasonable at first. But the way it identifies them is flawed:
- If compilation errors out, i.e. `RunCompiler::run` returns an `Err`, it uses `CompilationFailed`, which is reasonable.
- If compilation panics with `FatalError`, it catches the panic and uses `ICE`. This is sometimes right, because ICEs do cause `FatalError` panics, but sometimes wrong, because certain compiler errors also cause `FatalError` panics. (The compiler/rustdoc/clippy/whatever just catches the `FatalError` with `catch_with_exit_code` in `main`.)
In other words, certain non-ICE compilation failures get miscategorized as ICEs. It's not possible to reliably distinguish the two cases, so this commit merges them. It also renames the combined variant as just `Failed`, to better match the existing `Interrupted` and `Skipped` variants.
Here is an example of a non-ICE failure that causes a `FatalError` panic, from `tests/ui/recursion_limit/issue-105700.rs`:
```
#![recursion_limit="4"]
#![invalid_attribute]
#![invalid_attribute]
#![invalid_attribute]
#![invalid_attribute]
#![invalid_attribute]
//~^ERROR recursion limit reached while expanding
fn main() {{}}
```
r? ``@spastorino``
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/ArchiveWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
