about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
diff options
context:
space:
mode:
authorRich Kadel <richkadel@google.com>2021-04-24 15:29:44 -0700
committerRich Kadel <richkadel@google.com>2021-04-24 15:41:56 -0700
commit31cba57ea56e7444c75d62b3a1bebad8f5f74432 (patch)
tree518131eb79a31c7315144071ff96745d206556c1 /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
parent2b68027841af952d624a5ce509834237f8eda7e3 (diff)
downloadrust-31cba57ea56e7444c75d62b3a1bebad8f5f74432.tar.gz
rust-31cba57ea56e7444c75d62b3a1bebad8f5f74432.zip
Fix coverage ICE because fn_sig can have a span that crosses file boundaries
Fixes: #83792

MIR `InstrumentCoverage` assumed the `FnSig` span was contained within a
single file, but this is not always the case. Some macro constructions
can result in a span that starts in one `SourceFile` and ends in a
different one.

The `FnSig` span is included in coverage results as long as that span is
in the same `SourceFile` and the same macro context, but by assuming the
`FnSig` span's `hi()` and `lo()` were in the same file, I took this for
granted, and checked only that the `FnSig` `hi()` was in the same
`SourceFile` as the `body_span`.

I actually drop the `hi()` though, and extend the `FnSig` span to the
`body_span.lo()`, so I really should have simply checked that the
`FnSig` span's `lo()` was in the `SourceFile` of the `body_span`.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions