diff options
| author | bors <bors@rust-lang.org> | 2020-12-23 00:25:05 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-12-23 00:25:05 +0000 |
| commit | 5c981359a8ef753e87978d0323ba0eaf7def0769 (patch) | |
| tree | 0403c45ac9114b331ee07ee925dfabf92b14ad97 /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp | |
| parent | 971e5b33dafbe9a656b048d92d6cd39fddbcb152 (diff) | |
| parent | f055e7f2e9cc7233dd31384afdb303d362578012 (diff) | |
| download | rust-5c981359a8ef753e87978d0323ba0eaf7def0769.tar.gz rust-5c981359a8ef753e87978d0323ba0eaf7def0769.zip | |
Auto merge of #6483 - xFrednet:5386-github-ticket-search, r=killercup
Website issue tracker link and better search performance
This PR implements some improvements to the website:
1. Added a "Search on Github" link to the "Known problems" section (Closes #5386)
<details>
<summary>Another mock up I created with the GitHub logo</summary>
</details>
2. Only starting the search after three letters and improving the search performance in general. (Followup #6477)
### Testing
These changes can be tested locally by:
1. Clone this branch
2. Download the current lint index from the [gh-pages branch](https://github.com/rust-lang/rust-clippy/blob/gh-pages/master/lints.json)
3. Put it next to the `util/gh-pages/index.html` and open the html file. Make sure that it can load the lint data. (Browsers can be a bit iffy when opening a local html page and loading data)
### Sources for search performance:
1. [A stackoverflow about angular filter performance](https://stackoverflow.com/questions/26876514/optimize-angular-filter-performance)
* I selected a search debounce of 50ms that's fast enough to catch fast deletion and typing but responsive enough to not bother the user
2. [A stackoverflow about string comparison speeds](https://stackoverflow.com/questions/5296268/fastest-way-to-check-a-string-contain-another-substring-in-javascript)
3. [JS benchmarks for string search performance (`indexOf` seams to be the best)](https://jsben.ch/9cwLJ)
Note: The performance is still a bit poor when going from a specific lint to no search filter. I suspect that angular is recreating all lint items when the filter is cleared causing a major lag spike. The filter functions is at least optimized for little to no search.
---
changelog: Added a "Search on GitHub" link to the website
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions