diff options
| author | bors <bors@rust-lang.org> | 2024-09-30 08:22:29 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-09-30 08:22:29 +0000 |
| commit | 6938084f7e7333b4f3f5c2bc9add20062d381a24 (patch) | |
| tree | 5a9238b35ac37d3948fdb0626e3308c4623f5dea /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp | |
| parent | 1ca85ac7063cf6479d0fe0d879eb62a7c3c475cb (diff) | |
| parent | d8fb793739060b78e470567940b7e7f32e4b4e2a (diff) | |
| download | rust-6938084f7e7333b4f3f5c2bc9add20062d381a24.tar.gz rust-6938084f7e7333b4f3f5c2bc9add20062d381a24.zip | |
Auto merge of #18207 - mbwilding:master, r=Veykril
fix: Ambiguity with CamelCase diagnostic messages, align with rustc warnings
Fixed diagnostic messages so they say UpperCamelCase rather than CamelCase, as it is ambiguous.
Usually I'd call it PascalCase, but in the code base it is called UpperCamelCase so I left it with that naming choice.
`rustc` says `upper camel case` also when the case is wrong
```
warning: trait `testThing` should have an upper camel case name
--> src/main.rs:5:7
|
5 | trait testThing {
| ^^^^^^^^^ help: convert the identifier to upper camel case: `TestThing`
|
= note: `#[warn(non_camel_case_types)]` on by default
```
This is in line with the UPPER_SNAKE_CASE diagnostic messages.
https://github.com/rust-lang/rust-analyzer/blob/546339a7be357b3e95fc4b79a8816dce540d477b/crates/hir-ty/src/diagnostics/decl_check.rs#L60
https://github.com/rust-lang/rust-analyzer/blob/546339a7be357b3e95fc4b79a8816dce540d477b/crates/ide-diagnostics/src/handlers/incorrect_case.rs#L535
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions