diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-05-08 23:33:24 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-08 23:33:24 +0200 |
| commit | d30af5e16812d7c3d6cec2e597bcfce2b5866e49 (patch) | |
| tree | a45e3a6059c8e32ca9e65d7ebe21464be28507f6 /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp | |
| parent | c3202afa2865ad26ef407544c3768070bfed7bfe (diff) | |
| parent | 2d3a9a5847dccb2623c956e5aa175493fa68aa2a (diff) | |
| download | rust-d30af5e16812d7c3d6cec2e597bcfce2b5866e49.tar.gz rust-d30af5e16812d7c3d6cec2e597bcfce2b5866e49.zip | |
Rollup merge of #123344 - pietroalbini:pa-unused-imports, r=Nilstrieb
Remove braces when fixing a nested use tree into a single item
[Back in 2019](https://github.com/rust-lang/rust/pull/56645) I added rustfix support for the `unused_imports` lint, to automatically remove them when running `cargo fix`. For the most part this worked great, but when removing all but one childs of a nested use tree it turned `use foo::{Unused, Used}` into `use foo::{Used}`. This is slightly annoying, because it then requires you to run `rustfmt` to get `use foo::Used`.
This PR automatically removes braces and the surrouding whitespace when all but one child of a nested use tree are unused. To get it done I had to add the span of the nested use tree to the AST, and refactor a bit the code I wrote back then.
A thing I noticed is, there doesn't seem to be any `//@ run-rustfix` test for fixing the `unused_imports` lint. I created a test in `tests/suggestions` (is that the right directory?) that for now tests just what I added in the PR. I can followup in a separate PR to add more tests for fixing `unused_lints`.
This PR is best reviewed commit-by-commit.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions