about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2022-01-21 22:03:14 +0100
committerGitHub <noreply@github.com>2022-01-21 22:03:14 +0100
commite38cbc78aa18354a8b4e1477cd090bd83c298ced (patch)
treee7af78ff9601cdcba2bd921c36afe4ee4f7a1f7c /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
parent701a8330e8ee2135137fa3fed5154e5d03945df9 (diff)
parentaf87248037a8c86f580c469ce7d2a10c0b12f2fd (diff)
downloadrust-e38cbc78aa18354a8b4e1477cd090bd83c298ced.tar.gz
rust-e38cbc78aa18354a8b4e1477cd090bd83c298ced.zip
Rollup merge of #92835 - iwanders:issue-66450-improve-cfg-error-message, r=nagisa
Improve error message for key="value" cfg arguments.

Hi, I ran into difficulties using the `--cfg` flag syntax, first hit when googling for the error was issue https://github.com/rust-lang/rust/issues/66450. Reading that issue, it sounded like the best way to improve the experience was to improve the error message, this is low risk and doesn't introduce any additional argument parsing.

The issue mentions that it is entirely dependent on the shell, while this may be true, I think guiding the the user into the realization that the quotes may need to be escaped is helpful. The two suggested escapings both work in Bash and in the Windows command prompt.

fyi `@ehuss`
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions