about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-07-29 11:52:32 +0000
committerbors <bors@rust-lang.org>2024-07-29 11:52:32 +0000
commitee7212234224f463ca3818593ec395bd6a37d199 (patch)
tree3bc35c6788f3077284b1ed097d9beaf7b3edd957 /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
parent48fb66be7a657839bdf8f42ae06fc17893c2d162 (diff)
parent2f0451d113bd807a8d10ab667346f3fa77062632 (diff)
downloadrust-ee7212234224f463ca3818593ec395bd6a37d199.tar.gz
rust-ee7212234224f463ca3818593ec395bd6a37d199.zip
Auto merge of #17722 - joshka:jm/logs, r=Veykril
feat: use vscode log format for client logs

This change updates the log format to use the vscode log format instead
of the custom log format, by replacing the `OutputChannel` with a
`LogOutputChannel` and using the `debug`, `info`, `warn`, and `error`
methods on it. This has the following benefits:

- Each log level now has its own color and the timestamp is in a more
  standard format
- Inspect output (e.g. the log of the config object) is now colored
- Error stack traces are now shown in the output
- The log level is now controlled on the output tab by clicking the gear
  icon and selecting "Debug" or by passing the `--log` parameter to
  vscode. The `trace.extension` setting has been marked as deprecated.

Motivation:
The large uncolored unformatted log output with a large config object logged whenever it changes has always dominated the logs. This subjectively has made it that looking to see what the client is doing has always been a bit disappointing. That said, there's only 17 log messages total in the client. Hopefully by making the logs more visually useful this will encourage adding more appropriate debug level messages in future.

Incidentally, it might be worth only logging the config change message at a debug level instead of an info level to reduce the noise.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions