about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/Linker.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-11-08 13:38:08 +0000
committerbors <bors@rust-lang.org>2021-11-08 13:38:08 +0000
commit495322d776fd6f679cd8cd4ca02b8fa834da654b (patch)
treef74962afead566a9cdafeb4da75619a3f829ae9b /compiler/rustc_llvm/llvm-wrapper/Linker.cpp
parent3e3890c9d4064253aaa8c51f5d5458d2dc6dab77 (diff)
parent49e7c993ee4ab98f53898685394e9c2b3fa954dc (diff)
downloadrust-495322d776fd6f679cd8cd4ca02b8fa834da654b.tar.gz
rust-495322d776fd6f679cd8cd4ca02b8fa834da654b.zip
Auto merge of #90361 - Mark-Simulacrum:always-verify, r=michaelwoerister
Enable verification for 1/32th of queries loaded from disk

This is a limited enabling of incremental verification for query results loaded from disk, which previously did not run without -Zincremental-verify-ich. If enabled for all queries, we see a probably unacceptable hit of ~50% in the worst case, so this pairs back the verification to a more limited set based on the hash key.

Per collected [perf results](https://github.com/rust-lang/rust/pull/84227#issuecomment-953350582), this is a regression of at most 7% on coercions opt incr-unchanged, and typically less than 0.5% on other benchmarks (largely limited to incr-unchanged). I believe this is acceptable performance to land, and we can either ratchet it up or down fairly easily.

We have no real sense of whether this will lead to a large amount of assertions in the wild, but since those assertions may lead to miscompilations today, it seems potentially warranted. We have a good bit of lead time until the next stable release, though the holiday season will also start soon; we may wish to discuss the timing of enabling this and weigh the desire to prevent (possible) miscompilations against assertions.

cc `@rust-lang/wg-incr-comp`
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/Linker.cpp')
0 files changed, 0 insertions, 0 deletions