diff options
| author | bors <bors@rust-lang.org> | 2022-10-26 07:58:36 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-10-26 07:58:36 +0000 |
| commit | 136a1db50df706c5bd794c0f11e84fc58f3afa14 (patch) | |
| tree | 9b820af1baa9924d07c0ddbe24816a7acd7866f8 /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp | |
| parent | a46ccba167086f0b562eb78403f7446b0fed5f65 (diff) | |
| parent | 71e6815885f54631a2035e0c4d180a6de25ebccf (diff) | |
| download | rust-136a1db50df706c5bd794c0f11e84fc58f3afa14.tar.gz rust-136a1db50df706c5bd794c0f11e84fc58f3afa14.zip | |
Auto merge of #2614 - saethlin:stack-inspection-tools, r=RalfJung
Improve miri_print_borrow_stacks Per post-merge review on https://github.com/rust-lang/miri/pull/2322 * `miri_print_stacks` renamed to `miri_print_borrow_stacks` * A bit more details in docs, clarified how unstable these functions are meant to be * Print an `unknown_bottom` if one exists Open question: Currently `miri_get_alloc_id` gets the expected `AllocId` for `Wildcard` pointers, but for pointers with no provenance, the function reports UB and halts the interpreter. That's definitely wrong. But what _should_ we do? Is it reasonable to check if the pointer has `None` provenance and try to get an `AllocId` for its address? That still leaves us with a failure path, which in this case might be best-handled as an ICE? I'm just not sure that changing the return type of `miri_get_alloc_id` to `Option` is a win because it complicates all normal uses of this.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions