about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2022-12-05 20:43:41 +0100
committerGitHub <noreply@github.com>2022-12-05 20:43:41 +0100
commit4b6010cbb70bb903c0d69cddaa27e262cef15761 (patch)
tree5c2afbbb1d8d8a70a48ba7f97aadfc29c735d272 /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
parent8ad447c4791807a096b575ccba9baec2e4ec937d (diff)
parentb771d901f735aa6d4078aed92b03e30eba35bf5a (diff)
downloadrust-4b6010cbb70bb903c0d69cddaa27e262cef15761.tar.gz
rust-4b6010cbb70bb903c0d69cddaa27e262cef15761.zip
Rollup merge of #104952 - jyn514:setup, r=Mark-Simulacrum
Streamline the user experience for `x.py setup`

## Don't update submodules for x setup

Before, the submodule handling was very jank and would update *between two interactive prompts*:
```
; x setup
Building rustbuild
    Finished dev [unoptimized] target(s) in 0.05s
Welcome to the Rust project! What do you want to do with x.py?
a) library: Contribute to the standard library
Please choose one (a/b/c/d/e): a
Updating submodule library/backtrace
Submodule 'library/backtrace' (https://github.com/rust-lang/backtrace-rs.git) registered for path 'library/backtrace'
error: you asked `x.py` to setup a new config file, but one already exists at `config.toml`
Build completed unsuccessfully in 0:00:02
```

That's not a great user experience because you need to wait a long time between prompts.
It would be possible to move the submodule handling either before or after the prompt, but it seems
better to just not require submodules to be checked out at all, to minimize the time spend waiting
just to create a new configuration.

## Revamp the order setup executes

- Create `config.toml` last. It's the most likely to error, and used to stop later steps from executing
- Don't print an error message + exit if the git hook already exists; that's expected
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions