diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2022-09-06 17:00:26 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-06 17:00:26 +0200 |
| commit | 4d830b777536ac41adc3d48b6d78ec267078f197 (patch) | |
| tree | f879ec313d3337e9fe83a876837e4deae0b7aa4f /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp | |
| parent | d13aefdc65b933dc8dd8a2d1c58e5c4232d846d7 (diff) | |
| parent | 46ba27d5b54e4271e1c3934197afbae269237639 (diff) | |
| download | rust-4d830b777536ac41adc3d48b6d78ec267078f197.tar.gz rust-4d830b777536ac41adc3d48b6d78ec267078f197.zip | |
Rollup merge of #101434 - JhonnyBillM:replace-session-for-handler-in-into-diagnostic, r=davidtwco
Update `SessionDiagnostic::into_diagnostic` to take `Handler` instead of `ParseSess` Suggested by the team in [this Zulip Topic](https://rust-lang.zulipchat.com/#narrow/stream/336883-i18n/topic/.23100717.20SessionDiagnostic.20on.20Handler). `Handler` already has almost all the capabilities of `ParseSess` when it comes to diagnostic emission, in this migration we only needed to add the ability to access `source_map` from the emitter in order to get a `Snippet` and the `start_point`. Not sure if adding these two methods [`span_to_snippet_from_emitter` and `span_start_point_from_emitter`] is the best way to address this gap. P.S. If this goes in the right direction, then we probably may want to move `SessionDiagnostic` to `rustc_errors` and rename it to `DiagnosticHandler` or something similar. r? `@davidtwco` r? `@compiler-errors`
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions