about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
diff options
context:
space:
mode:
authorJoshua Nelson <jnelson@cloudflare.com>2022-11-26 15:00:39 -0500
committerJoshua Nelson <jnelson@cloudflare.com>2022-11-26 15:50:01 -0500
commit71fd3abc73471bf1b68666c980d73c4385e5e9a7 (patch)
tree497f40a597262c48e17bce02cb87f316fb2cc7dc /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
parent8841bee954ecf0e6820c9990feb3a76cb04e7d96 (diff)
downloadrust-71fd3abc73471bf1b68666c980d73c4385e5e9a7.tar.gz
rust-71fd3abc73471bf1b68666c980d73c4385e5e9a7.zip
Don't update submodules for `x setup`
Before, the submodule handling was very jank and would update *between two interactive prompts*:
```
; x setup
Building rustbuild
    Finished dev [unoptimized] target(s) in 0.05s
Welcome to the Rust project! What do you want to do with x.py?
a) library: Contribute to the standard library
Please choose one (a/b/c/d/e): a
Updating submodule library/backtrace
Submodule 'library/backtrace' (https://github.com/rust-lang/backtrace-rs.git) registered for path 'library/backtrace'
error: you asked `x.py` to setup a new config file, but one already exists at `config.toml`
Build completed unsuccessfully in 0:00:02
```

That's not a great user experience because you need to wait a long time between prompts.
It would be possible to move the submodule handling either before or after the prompt, but it seems
better to just not require submodules to be checked out at all, to minimize the time spend waiting
just to create a new configuration.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions