about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
diff options
context:
space:
mode:
authorAugie Fackler <augie@google.com>2021-03-22 14:37:49 -0400
committerAugie Fackler <augie@google.com>2021-03-22 14:37:49 -0400
commit9431e8577d44dcc463134275421a6da6d862c377 (patch)
treec67e734100d95eabee7c40fda3ac7294f10682a0 /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
parentbabe894bab47e43c2a884fe367095905e4e88993 (diff)
downloadrust-9431e8577d44dcc463134275421a6da6d862c377.tar.gz
rust-9431e8577d44dcc463134275421a6da6d862c377.zip
cleanup: add some comments per review feedback
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
-rw-r--r--compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp b/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
index f1a898b324c..22ceb57762b 100644
--- a/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
+++ b/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
@@ -1438,6 +1438,9 @@ LLVMRustCreateThinLTOData(LLVMRustThinLTOModule *modules,
   };
 
 #if LLVM_VERSION_GE(13,0)
+  // Uses FromPrevailing visibility scheme which works for many binary
+  // formats. We probably could and should use ELF visibility scheme for many of
+  // our targets, however.
   lto::Config conf;
   thinLTOResolvePrevailingInIndex(conf, Ret->Index, isPrevailing, recordNewLinkage,
                                   Ret->GUIDPreservedSymbols);