about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
diff options
context:
space:
mode:
authorEd Page <eopage@gmail.com>2025-01-27 14:04:49 -0600
committerEd Page <eopage@gmail.com>2025-04-17 13:30:59 -0500
commitaa8670f6f81dac097d24277e7559ce5abf5d5183 (patch)
treea8c63f2350d4b75c38415a6c599639eeca84269d /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
parent11f7290c9f9122c5f2c47802c1883b2a0a04aed9 (diff)
downloadrust-aa8670f6f81dac097d24277e7559ce5abf5d5183.tar.gz
rust-aa8670f6f81dac097d24277e7559ce5abf5d5183.zip
fix(test): Expose '--no-capture', deprecating '--nocapture'
This improves consistency with commonly expected CLI conventions,
avoiding a common stutter people make when running tests (trying what
they expect and then having to check the docs to then user whats
accepted).

An alternative could have been to take a value, like `--capture <value>` (e.g. `pytest` does this).
Overall, we're shifting focus for features to custom test harnesses (see #134283).
Most of `pytest`s modes will likely be irrelevant in that situation.
As for the rest, its too early to tell which, if any, may be relevant,
so we're sticking with this small, quality of life improvement.

By deprecating `--nocapture`, we intend that custom test harnesses do
not need to support it for reasons outside of their own compatibility
requirements, much like the deprecation in #134283

I'm punting for now on the naming of `RUST_TEST_NOCAPTURE`.
I feel like T-testing-devex should do a wider look at environment
variables role in lib`test` before evaluating whether to
- Deprecate it in favor of the user passing CLI flags or the test runner
  providing its own config
- Deprecate in favor of `RUST_TEST_NO_CAPTURE`
- Deprecate in favor of `RUST_TEST_CAPTURE`

Other CLI flags were evaluated for casing consistency:
- `--logfile` has the same problem but was deprecated in #134283

Fixes #133073
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions