about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-11-15 16:10:19 +0000
committerbors <bors@rust-lang.org>2021-11-15 16:10:19 +0000
commitc26746af5a925bad66b7ed4f9e7c3018f00d4010 (patch)
tree4ca03e28d3878887d0be3898d31dd4986d0c51a2 /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
parenteab2d7519a3f1c11ddaff3d19f8b7727354c6362 (diff)
parentafa719e2eed83d7a7820e3a26194a26d55029536 (diff)
downloadrust-c26746af5a925bad66b7ed4f9e7c3018f00d4010.tar.gz
rust-c26746af5a925bad66b7ed4f9e7c3018f00d4010.zip
Auto merge of #90473 - joshtriplett:stabilize-format-args-capture, r=Mark-Simulacrum
stabilize format args capture

Works as expected, and there are widespread reports of success with it, as well as interest in it.

RFC: rust-lang/rfcs#2795
Tracking issue: https://github.com/rust-lang/rust/issues/67984

Addressing items from the tracking issue:

- We don't support capturing arguments from a non-literal format string like `format_args!(concat!(...))`. We could add that in a future enhancement, or we can decide that it isn't supported (as suggested in https://github.com/rust-lang/rust/issues/67984#issuecomment-801394736 ).
- I've updated the documentation.
- `panic!` now supports capture as well.
- There are potentially opportunities to further improve diagnostics for invalid usage, such as if it looks like the user tried to use an expression rather than a variable. However, such cases are all already caught and provide reasonable syntax errors now, and we can always provided even friendlier diagnostics in the future.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions