diff options
| author | Catherine Flores <catherine.3.flores@gmail.com> | 2025-01-12 15:15:51 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-12 15:15:51 +0000 |
| commit | d648cc9a2c3a852d0de5ae8121081f3225d5dc7f (patch) | |
| tree | 4ddab76402b9cd68da7eca3143995e5ff8c139cf /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp | |
| parent | 34d109fd263a7a22386eeaea0a8c013ab93b9a74 (diff) | |
| parent | 5f757153981b3e6cc8f36d53473906c7b6b7698b (diff) | |
| download | rust-d648cc9a2c3a852d0de5ae8121081f3225d5dc7f.tar.gz rust-d648cc9a2c3a852d0de5ae8121081f3225d5dc7f.zip | |
Do not trigger `redundant_pub_crate` in external macros (#13952)
Some widely used crates, such as `pin-project-lite`, make use of a `pub(crate)` construct in a private module inside a public macro. This makes unrelated project trigger the lint. There is also an unfortunate situation for Clippy itself: when a new version of `pin-project-lite` or similar lint-trigerring crates is released, those lints which can be found in hundreds of occurrences in dependent crates will change, and appear as diffs in unrelated Clippy PR because the base lintcheck run will be cached with the ancient release of the crates. We currently have the situation [here](https://github.com/rust-lang/rust-clippy/actions/runs/12635410895?pr=13851#user-content-redundant-pub-crate-removed), which 219 lints removed and 219 lints added because of a `pin-project-lite` version change between runs, and the fact that `redundant_pub_crate` triggers on external macros. Also: - Fix #10636 - Fix #12213 changelog: [`redundant_pub_crate`]: do not trigger on external macros
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions