about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-07-20 10:56:08 +0000
committerbors <bors@rust-lang.org>2021-07-20 10:56:08 +0000
commitda7d405357600a76f2b93b8aa41fe5ee5da7885d (patch)
tree9763cf30603b2489abef4a9fefe570465c287b29 /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
parent718d53b0cb7dde93499cb92950d60b412f5a3d05 (diff)
parentae024919845a44473c22b8c3f1dfa075c9c5c75d (diff)
downloadrust-da7d405357600a76f2b93b8aa41fe5ee5da7885d.tar.gz
rust-da7d405357600a76f2b93b8aa41fe5ee5da7885d.zip
Auto merge of #87244 - jackh726:issue-71883, r=estebank
Better diagnostics with mismatched types due to implicit static lifetime

Fixes #78113

I think this is my first diagnostics PR...definitely happy to hear thoughts on the direction/implementation here.

I was originally just trying to solve the error above, where the lifetime on a GAT was causing a cryptic "mismatched types" error. But as I was writing this, I realized that this (unintentionally) also applied to a different case: `wf-in-foreign-fn-decls-issue-80468.rs`. I'm not sure if this diagnostic should get a new error code, or even reuse an existing one. And, there might be some ways to make this even more generalized. Also, the error is a bit more lengthy and verbose than probably needed. So thoughts there are welcome too.

This PR essentially ended up adding a new nice region error pass that triggers if a type doesn't match the self type of an impl which is selected because of a predicate because of an implicit static bound on that self type.

r? `@estebank`
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions