about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-09-16 03:36:03 +0000
committerbors <bors@rust-lang.org>2024-09-16 03:36:03 +0000
commit39b7669347b02f25a36da610822fb3c1e03bac6c (patch)
treeb7485eae8c160e9095aacdd64ca127413faef627 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
parentc16ff44537509ca911ffd3653b17c6187c71831d (diff)
parentb72b42d36faf301f8cd6c31372525ab69ed752cc (diff)
downloadrust-39b7669347b02f25a36da610822fb3c1e03bac6c.tar.gz
rust-39b7669347b02f25a36da610822fb3c1e03bac6c.zip
Auto merge of #130220 - RalfJung:float-classify, r=workingjubilee
simplify float::classify logic

I played around with the float-classify test in the hope of triggering x87 bugs by strategically adding `black_box`, and still the exact expression `@beetrees` suggested [here](https://github.com/rust-lang/rust/pull/129835#issuecomment-2325661597) remains the only case I found where we get the wrong result on x87. Curiously, this bug only occurs when MIR optimizations are enabled -- probably the extra inlining that does is required for LLVM to hit the right "bad" case in the backend. But even for that case, it makes no difference whether `classify` is implemented in the simple bit-pattern-based version or the more complicated version we had before.

Without even a single testcase that can distinguish our `classify` from the naive version, I suggest we switch to the naive version.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions