diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2022-03-14 17:24:58 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-14 17:24:58 +0100 |
| commit | 6548a368c8c66c802ba710dd9fede228dc65587e (patch) | |
| tree | e16d7650112a4673530e53023d13536dd8450215 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp | |
| parent | 774655da5fabdef01f862c50d1796abbe59efb7d (diff) | |
| parent | be84049570d5be6d6e76e471ef88a11ae46292ad (diff) | |
| download | rust-6548a368c8c66c802ba710dd9fede228dc65587e.tar.gz rust-6548a368c8c66c802ba710dd9fede228dc65587e.zip | |
Rollup merge of #94670 - xFrednet:rfc-2383-expect-impl-after-party, r=flip1995,wesleywiser
Improve `expect` impl and handle `#[expect(unfulfilled_lint_expectations)]` (RFC 2383) This PR updates unstable `ExpectationIds` in stashed diagnostics and adds some asserts to ensure that the stored expectations are really empty in the end. Additionally, it handles the `#[expect(unfulfilled_lint_expectations)]` case. According to the [Errors and lints docs](https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels) the `error` level should only be used _"when the compiler detects a problem that makes it unable to compile the program"_. As this isn't the case with `#[expect(unfulfilled_lint_expectations)]` I decided to only create a warning. To avoid adding a new lint only for this case, I simply emit a `unfulfilled_lint_expectations` diagnostic with an additional note. --- r? `@wesleywiser` I'm requesting a review from you since you reviewed the previous PR https://github.com/rust-lang/rust/pull/87835. You are welcome to reassign it if you're busy :upside_down_face: rfc: [RFC-2383](https://rust-lang.github.io/rfcs/2383-lint-reasons.html) tracking issue: https://github.com/rust-lang/rust/issues/85549 cc: `@flip1995` In case you're also interested in this :)
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
