diff options
| author | bors <bors@rust-lang.org> | 2021-02-07 11:15:44 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2021-02-07 11:15:44 +0000 |
| commit | 83b7b1633023fb4f271be042268d4a14b56d7db0 (patch) | |
| tree | 73250b2b2fd7852e652306ccb9a5540754e28d44 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp | |
| parent | ad9ceeebdcce3d844c065777d1c2d3d74aff0047 (diff) | |
| parent | 7b7e3ca5116983f5485bc9c8a5b2abf490900241 (diff) | |
| download | rust-83b7b1633023fb4f271be042268d4a14b56d7db0.tar.gz rust-83b7b1633023fb4f271be042268d4a14b56d7db0.zip | |
Auto merge of #6674 - phlip9:disallowed_functions, r=llogiq
disallowed_methods: Support functions in addition to methods ## Context: Hey all! I have a particular use case where I'd like to ban certain functions in a code base I work on. For example, I want to ban `Instant::now()` (among others) as we have a time service for mocking time in deterministic simulation tests. Obviously, it doesn't make sense to include a lint like this for all clippy users. Imagine my excitement when I spotted the new `disallowed_methods` lint in clippy--perfect! Unfortunately, after playing around with it for a bit, I was frustrated to realize that it didn't support functions like `Instant::now()`, so I've added support for them in this PR. It might also make sense to rename the lint from `disallowed_methods` -> `disallowed_functions`, though I've held off from including that rename in this change, since I'm unsure of clippy's breaking change policy. ## Change Support functions in addition to methods. In other words, support: `disallowed_methods = ["alloc::vec::Vec::new"]` (a function) in addition to `disallowed_methods = ["alloc::vec::Vec::leak"]` (a method). Improve the documentation to clarify that users must specify the full qualified path for each disallowed function, which can be confusing for reexports. Include an example `clippy.toml`. Simplify the actual lint pass so we can reuse `utils::fn_def_id`. changelog: disallowed_method: Now supports functions in addition to methods
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
