about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
diff options
context:
space:
mode:
authorNicholas Nethercote <n.nethercote@gmail.com>2023-12-04 14:27:43 +1100
committerNicholas Nethercote <n.nethercote@gmail.com>2023-12-04 18:57:42 +1100
commit883bdb7fda9b2eda5e3c1846ed653e7edf4936c4 (patch)
treeac98dc640cac1388b5baf28b402a1f5872abd398 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
parenta8ff867d5c3f88224cfec66f36b697cac0c6f75e (diff)
downloadrust-883bdb7fda9b2eda5e3c1846ed653e7edf4936c4.tar.gz
rust-883bdb7fda9b2eda5e3c1846ed653e7edf4936c4.zip
Remove `HandlerInner::emit`.
This is weird: `HandlerInner::emit` calls
`HandlerInner::emit_diagnostic`, but only after doing a
`treat-err-as-bug` check. Which is fine, *except* that there are
multiple others paths for an `Error` or `Fatal` diagnostic to be passed
to `HandlerInner::emit_diagnostic` without going through
`HandlerInner::emit`, e.g. `Handler::span_err` call
`Handler::emit_diag_at_span`, which calls `emit_diagnostic`.
So that suggests that the coverage for `treat-err-as-bug` is incomplete.

This commit removes `HandlerInner::emit` and moves the
`treat-err-as-bug` check to `HandlerInner::emit_diagnostic`, so it
cannot by bypassed.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions