about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
diff options
context:
space:
mode:
authorMatthias Krüger <476013+matthiaskrgr@users.noreply.github.com>2025-03-13 10:58:15 +0100
committerGitHub <noreply@github.com>2025-03-13 10:58:15 +0100
commitb3ab69504aaa3cb0e91cafb3a0dd64c502915a32 (patch)
treea0161c9f4f8aaad1df363f7a5ccea85971b94adf /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
parent3b1776dc292d057f59ed94de0d2c14ff43d73a55 (diff)
parenta05d6ab8b7b303c4b2010f57c1a496e1f8f90216 (diff)
downloadrust-b3ab69504aaa3cb0e91cafb3a0dd64c502915a32.tar.gz
rust-b3ab69504aaa3cb0e91cafb3a0dd64c502915a32.zip
Rollup merge of #133981 - aDotInTheVoid:document-docs-ids, r=fmease
rustdoc-json: Refractor and document Id's

Closes #133780

While working on documenting Id's, I realized alot of the way they were generated was weird and unnecessary. Eg:

1. The fully uninterned id type was `(FullItemId, Option<FullItemId>)`, meaning it wasn't actually full!
2. None of the extra fields in `Option<FullItemId>` would ever be used
3. `imported_item_id` was a `rustdoc_json_types::Id` instead of a simpler `DefId`.

I believe the new implementation still covers all the same cases, but in a more principled way (and explaining why each piece is needed).

This was written to be reviewed commit-by-commit, but it might be easier to review all at once if you're not interested in tracking how the original code became the final code.

cc ``@its-the-shrimp``

r? ``@fmease``
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions