about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
diff options
context:
space:
mode:
authorJubilee <workingjubilee@gmail.com>2024-10-28 10:18:52 -0700
committerGitHub <noreply@github.com>2024-10-28 10:18:52 -0700
commitbd43f8e9fdda660eb0165c87c270aba189bd5a95 (patch)
treeb5131fe0d980d059246d0b45f3bb7a5dac534801 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
parent6ea83ffe2ca3cbe576bf8b1dcd25a353da2374e6 (diff)
parent4bd84b23a8537314132e98b9fb2c3fea2cb57496 (diff)
downloadrust-bd43f8e9fdda660eb0165c87c270aba189bd5a95.tar.gz
rust-bd43f8e9fdda660eb0165c87c270aba189bd5a95.zip
Rollup merge of #132260 - Zalathar:type-safe-cast, r=compiler-errors
cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`

In `rustc_codegen_llvm` there are many uses of `.as_ptr().cast()` to convert a string or byte-slice to `*const c_char`, which then gets passed through FFI.

This works, but is fragile, because there's nothing constraining the pointer cast to actually be from `u8` to `c_char`. If the original value changes to something else that has an `as_ptr` method, or the context changes to expect something other than `c_char`, the cast will silently do the wrong thing.

By making the cast more explicit via a helper method, we can be sure that it will either perform the intended cast, or fail at compile time.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions