about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/SymbolWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2023-08-19 13:35:02 +0000
committerbors <bors@rust-lang.org>2023-08-19 13:35:02 +0000
commit904b326c118bd4e3e1b4b7103eee5a98c3c8424e (patch)
treec40d2a6cba33557e6d97c24e3f50a1d43e1c9780 /compiler/rustc_llvm/llvm-wrapper/SymbolWrapper.cpp
parent721e0e3512c11028221edb4cbee2c03baff54848 (diff)
parent6c46b98a9532b93c538b3553a7ff6ab4aa50655c (diff)
downloadrust-904b326c118bd4e3e1b4b7103eee5a98c3c8424e.tar.gz
rust-904b326c118bd4e3e1b4b7103eee5a98c3c8424e.zip
Auto merge of #15482 - matklad:🪄deblobify, r=Veykril
fix: avoid problematic serde release

serde 1.0.172 and up rely on opaque non-reproducible binary blobs to function, explicitly not providing a library-level opt-out.

This is problematic for two reasons:

- directly, unauditable binary blobs are a security issue.
- indirectly, it becomes much harder to predict future behaviors of the crate.

As such, I am willing to go on a limb here and forbid building rust-analyzer with those versions of serde. Normally, my philosophy is to defer the choice to the end user, but it's also a design constraint of rust-analyzer that we don't run random binaries downloaded from the internet without explicit user's concent.

Concretely, this upper-bounds serde for both rust-analyzer workspace, as well as the lsp-server lib.

See https://github.com/serde-rs/serde/issues/2538 for wider context.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/SymbolWrapper.cpp')
0 files changed, 0 insertions, 0 deletions