about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-11-13 06:07:27 +0000
committerbors <bors@rust-lang.org>2024-11-13 06:07:27 +0000
commitec239b888f3945a6ce043db639f1741d14f08874 (patch)
tree11b6f9a11c6254b26dcb0f7d3ab35b29c2cd40f5 /compiler/rustc_llvm/llvm-wrapper
parent44f233f2519ce5d633c87c38014d03d8a5f0e810 (diff)
parent46603166d7f5cae49f38a3595e2f424a3063c20b (diff)
downloadrust-ec239b888f3945a6ce043db639f1741d14f08874.tar.gz
rust-ec239b888f3945a6ce043db639f1741d14f08874.zip
Auto merge of #132886 - fmease:rustdoc-perf-clean-middle-args, r=GuillaumeGomez
[perf] rustdoc: Perform less work when cleaning middle::ty parenthesized generic args

CC #132697. I presume the perf regression it caused (if real) boils down to query invocation overhead, namely of `def_kind` & `trait_def` as we don't seem to be decoding more often from the crate metadata.

I won't try the obvious and reduce the amount of query calls by threading information via params as that would render the code awkward.

So instead I'm simply trying to attack some low-hanging fruits in the vicinity.

---

Previously, we would `clean_middle_generic_args` *unconditionally* inside `clean_middle_generic_args_with_constraints` even though we didn't actually use its result for parenthesized generic args (`Trait(...) -> ...`).

Now, we only call `clean_middle_generic_args` when necessary. Lastly, I've simplified `clean_middle_generic_args_with_constraints`.

---

r? ghost
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper')
0 files changed, 0 insertions, 0 deletions