about summary refs log tree commit diff
path: root/compiler/rustc_llvm
diff options
context:
space:
mode:
authorMara Bos <m-ou.se@m-ou.se>2020-11-12 19:46:09 +0100
committerGitHub <noreply@github.com>2020-11-12 19:46:09 +0100
commit755dd14e00fd9007a67779b129e81b47c6435113 (patch)
tree8082b642e059fe77959dfea3893351db34c3f872 /compiler/rustc_llvm
parent4b0b42a2808e9d1f4f49bc9e3767f90feacbd152 (diff)
parentde84ad95b4b097e504171c7c606bf3715803c13b (diff)
downloadrust-755dd14e00fd9007a67779b129e81b47c6435113.tar.gz
rust-755dd14e00fd9007a67779b129e81b47c6435113.zip
Rollup merge of #78836 - fanzier:struct-and-slice-destructuring, r=petrochenkov
Implement destructuring assignment for structs and slices

This is the second step towards implementing destructuring assignment (RFC: rust-lang/rfcs#2909, tracking issue: #71126). This PR is the second part of #71156, which was split up to allow for easier review.

Note that the first PR (#78748) is not merged yet, so it is included as the first commit in this one. I thought this would allow the review to start earlier because I have some time this weekend to respond to reviews. If ``@petrochenkov`` prefers to wait until the first PR is merged, I totally understand, of course.

This PR implements destructuring assignment for (tuple) structs and slices. In order to do this, the following *parser change* was necessary: struct expressions are not required to have a base expression, i.e. `Struct { a: 1, .. }` becomes legal (in order to act like a struct pattern).

Unfortunately, this PR slightly regresses the diagnostics implemented in #77283. However, it is only a missing help message in `src/test/ui/issues/issue-77218.rs`. Other instances of this diagnostic are not affected. Since I don't exactly understand how this help message works and how to fix it yet, I was hoping it's OK to regress this temporarily and fix it in a follow-up PR.

Thanks to ``@varkor`` who helped with the implementation, particularly around the struct rest changes.

r? ``@petrochenkov``
Diffstat (limited to 'compiler/rustc_llvm')
0 files changed, 0 insertions, 0 deletions