diff options
| author | Mark Rousskov <mark.simulacrum@gmail.com> | 2021-10-12 10:43:39 -0400 |
|---|---|---|
| committer | Mark Rousskov <mark.simulacrum@gmail.com> | 2021-11-22 21:22:35 -0500 |
| commit | 3228603cce1bcb81a48171cf5e2083ee0cda7fd9 (patch) | |
| tree | 04eec4981c8631c3d091e7d488e0548048439355 /compiler/rustc_macros/src/serialize.rs | |
| parent | 65f3f8b220f020e562c5dd848ff7319257a7ba45 (diff) | |
| download | rust-3228603cce1bcb81a48171cf5e2083ee0cda7fd9.tar.gz rust-3228603cce1bcb81a48171cf5e2083ee0cda7fd9.zip | |
Avoid generating empty closures for fieldless enums
For many enums, this avoids generating lots of tiny stubs that need to be codegen'd and then inlined and removed by LLVM.
Diffstat (limited to 'compiler/rustc_macros/src/serialize.rs')
| -rw-r--r-- | compiler/rustc_macros/src/serialize.rs | 25 |
1 files changed, 18 insertions, 7 deletions
diff --git a/compiler/rustc_macros/src/serialize.rs b/compiler/rustc_macros/src/serialize.rs index 7bc669f2b00..66e6b571beb 100644 --- a/compiler/rustc_macros/src/serialize.rs +++ b/compiler/rustc_macros/src/serialize.rs @@ -247,13 +247,24 @@ fn encodable_body( }) .collect(); - let result = quote! { ::rustc_serialize::Encoder::emit_enum_variant( - __encoder, - #variant_name, - #variant_idx, - #field_idx, - |__encoder| { ::std::result::Result::Ok({ #encode_fields }) } - ) }; + let result = if field_idx != 0 { + quote! { + ::rustc_serialize::Encoder::emit_enum_variant( + __encoder, + #variant_name, + #variant_idx, + #field_idx, + |__encoder| { ::std::result::Result::Ok({ #encode_fields }) } + ) + } + } else { + quote! { + ::rustc_serialize::Encoder::emit_fieldless_enum_variant::<#variant_idx>( + __encoder, + #variant_name, + ) + } + }; variant_idx += 1; result }); |
