diff options
| author | Nicholas Nethercote <n.nethercote@gmail.com> | 2022-06-22 16:11:14 +1000 |
|---|---|---|
| committer | Nicholas Nethercote <n.nethercote@gmail.com> | 2022-08-01 08:01:58 +1000 |
| commit | d4a5b034b75c7ea3d9a7955857f56ecc7d7b9cca (patch) | |
| tree | 6ca86f987fb459f2b3cf281dde55e1b0fce0d35e /compiler/rustc_macros | |
| parent | 038f9e6bef9c8fcf122d93a8a33ac546f5606eb3 (diff) | |
| download | rust-d4a5b034b75c7ea3d9a7955857f56ecc7d7b9cca.tar.gz rust-d4a5b034b75c7ea3d9a7955857f56ecc7d7b9cca.zip | |
Don't derive `PartialEq::ne`.
Currently we skip deriving `PartialEq::ne` for C-like (fieldless) enums and empty structs, thus reyling on the default `ne`. This behaviour is unnecessarily conservative, because the `PartialEq` docs say this: > Implementations must ensure that eq and ne are consistent with each other: > > `a != b` if and only if `!(a == b)` (ensured by the default > implementation). This means that the default implementation (`!(a == b)`) is always good enough. So this commit changes things such that `ne` is never derived. The motivation for this change is that not deriving `ne` reduces compile times and binary sizes. Observable behaviour may change if a user has defined a type `A` with an inconsistent `PartialEq` and then defines a type `B` that contains an `A` and also derives `PartialEq`. Such code is already buggy and preserving bug-for-bug compatibility isn't necessary. Two side-effects of the change: - There is only one error message produced for types where `PartialEq` cannot be derived, instead of two. - For coverage reports, some warnings about generated `ne` methods not being executed have disappeared. Both side-effects seem fine, and possibly preferable.
Diffstat (limited to 'compiler/rustc_macros')
0 files changed, 0 insertions, 0 deletions
