diff options
| author | Wesley Wiser <wesleywiser@microsoft.com> | 2022-10-14 18:44:30 -0400 |
|---|---|---|
| committer | Wesley Wiser <wesleywiser@microsoft.com> | 2022-10-14 18:44:30 -0400 |
| commit | 34d90a46dac95d6f09cd8851b71b43350eecda4d (patch) | |
| tree | 6ad3214cee7e870e3e2d02e7e54a8f78f2e0a146 /compiler/rustc_middle/src | |
| parent | 9363a1401e2d0061c810504c7be169badd5a910b (diff) | |
| download | rust-34d90a46dac95d6f09cd8851b71b43350eecda4d.tar.gz rust-34d90a46dac95d6f09cd8851b71b43350eecda4d.zip | |
Fix line numbers for MIR inlined code
`should_collapse_debuginfo` detects if the specified span is part of a macro expansion however it does this by checking if the span is anything other than a normal (non-expanded) kind, then the span sequence is walked backwards to the root span. This doesn't work when the MIR inliner inlines code as it creates spans with expansion information set to `ExprKind::Inlined` and results in the line number being attributed to the inline callsite rather than the normal line number of the inlined code.
Diffstat (limited to 'compiler/rustc_middle/src')
| -rw-r--r-- | compiler/rustc_middle/src/ty/mod.rs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/compiler/rustc_middle/src/ty/mod.rs b/compiler/rustc_middle/src/ty/mod.rs index 0d7d4054bb3..34938ab05cb 100644 --- a/compiler/rustc_middle/src/ty/mod.rs +++ b/compiler/rustc_middle/src/ty/mod.rs @@ -2522,7 +2522,9 @@ impl<'tcx> TyCtxt<'tcx> { && if self.features().collapse_debuginfo { span.in_macro_expansion_with_collapse_debuginfo() } else { - span.from_expansion() + // Inlined spans should not be collapsed as that leads to all of the + // inlined code being attributed to the inline callsite. + span.from_expansion() && !span.is_inlined() } } |
