diff options
| author | Aaron Hill <aa1ronham@gmail.com> | 2021-04-04 16:55:39 -0400 |
|---|---|---|
| committer | Aaron Hill <aa1ronham@gmail.com> | 2021-07-16 16:29:02 -0500 |
| commit | a7653337380071ebc5b83a8133121b87dc892442 (patch) | |
| tree | 731dc884e12d998b11796e2dbdf2cb08cbe2dcce /compiler/rustc_mir/src/transform/coverage/debug.rs | |
| parent | 59d92bd0173fb0436b93aa56ff2cb288d4717701 (diff) | |
| download | rust-a7653337380071ebc5b83a8133121b87dc892442.tar.gz rust-a7653337380071ebc5b83a8133121b87dc892442.zip | |
Add initial implementation of HIR-based WF checking for diagnostics
During well-formed checking, we walk through all types 'nested' in generic arguments. For example, WF-checking `Option<MyStruct<u8>>` will cause us to check `MyStruct<u8>` and `u8`. However, this is done on a `rustc_middle::ty::Ty`, which has no span information. As a result, any errors that occur will have a very general span (e.g. the definintion of an associated item). This becomes a problem when macros are involved. In general, an associated type like `type MyType = Option<MyStruct<u8>>;` may have completely different spans for each nested type in the HIR. Using the span of the entire associated item might end up pointing to a macro invocation, even though a user-provided span is available in one of the nested types. This PR adds a framework for HIR-based well formed checking. This check is only run during error reporting, and is used to obtain a more precise span for an existing error. This is accomplished by individually checking each 'nested' type in the HIR for the type, allowing us to find the most-specific type (and span) that produces a given error. The majority of the changes are to the error-reporting code. However, some of the general trait code is modified to pass through more information. Since this has no soundness implications, I've implemented a minimal version to begin with, which can be extended over time. In particular, this only works for HIR items with a corresponding `DefId` (e.g. it will not work for WF-checking performed within function bodies).
Diffstat (limited to 'compiler/rustc_mir/src/transform/coverage/debug.rs')
0 files changed, 0 insertions, 0 deletions
