diff options
| author | Nicholas Nethercote <n.nethercote@gmail.com> | 2023-05-16 16:04:03 +1000 |
|---|---|---|
| committer | Nicholas Nethercote <n.nethercote@gmail.com> | 2023-05-16 17:59:56 +1000 |
| commit | 01e33a3600789b0e96511c4ac95fc114b507c79e (patch) | |
| tree | 7791bb92e126bb96aab5365886ef218cfb47e726 /compiler/rustc_mir_transform/src/coverage/graph.rs | |
| parent | 87a2bc027c4cfd126bc95f864d229d5cb5f7f00c (diff) | |
| download | rust-01e33a3600789b0e96511c4ac95fc114b507c79e.tar.gz rust-01e33a3600789b0e96511c4ac95fc114b507c79e.zip | |
Avoid `&format("...")` calls in error message code.
Error message all end up passing into a function as an `impl
Into<{D,Subd}iagnosticMessage>`. If an error message is creatd as
`&format("...")` that means we allocate a string (in the `format!`
call), then take a reference, and then clone (allocating again) the
reference to produce the `{D,Subd}iagnosticMessage`, which is silly.
This commit removes the leading `&` from a lot of these cases. This
means the original `String` is moved into the
`{D,Subd}iagnosticMessage`, avoiding the double allocations. This
requires changing some function argument types from `&str` to `String`
(when all arguments are `String`) or `impl
Into<{D,Subd}iagnosticMessage>` (when some arguments are `String` and
some are `&str`).
Diffstat (limited to 'compiler/rustc_mir_transform/src/coverage/graph.rs')
0 files changed, 0 insertions, 0 deletions