diff options
| author | Michael Goulet <michael@errs.io> | 2024-06-24 15:51:03 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-24 15:51:03 -0400 |
| commit | 9ce2a070b3fbb053644c8f0ae569957ae08034e4 (patch) | |
| tree | 93fefed36bcbce497e0b3e828186816f0cfd388e /compiler/rustc_mir_transform/src/coverage/mod.rs | |
| parent | 49bdf460a22ee85e27b311f3cde099cfa592f865 (diff) | |
| parent | 1852141219b39b2a6bb13ad273c96371d58a41e0 (diff) | |
| download | rust-9ce2a070b3fbb053644c8f0ae569957ae08034e4.tar.gz rust-9ce2a070b3fbb053644c8f0ae569957ae08034e4.zip | |
Rollup merge of #126682 - Zalathar:coverage-attr, r=lcnr
coverage: Overhaul validation of the `#[coverage(..)]` attribute This PR makes sweeping changes to how the (currently-unstable) coverage attribute is validated: - Multiple coverage attributes on the same item/expression are now treated as an error. - The attribute must always be `#[coverage(off)]` or `#[coverage(on)]`, and the error messages for this are more consistent. - A trailing comma is still allowed after off/on, since that's part of the normal attribute syntax. - Some places that silently ignored a coverage attribute now produce an error instead. - These cases were all clearly bugs. - Some places that ignored a coverage attribute (with a warning) now produce an error instead. - These were originally added as lints, but I don't think it makes much sense to knowingly allow new attributes to be used in meaningless places. - Some of these errors might soon disappear, if it's easy to extend recursive coverage attributes to things like modules and impl blocks. --- One of the goals of this PR is to lay a more solid foundation for making the coverage attribute recursive, so that it applies to all nested functions/closures instead of just the one it is directly attached to. Fixes #126658. This PR incorporates #126659, which adds more tests for validation of the coverage attribute. `@rustbot` label +A-code-coverage
Diffstat (limited to 'compiler/rustc_mir_transform/src/coverage/mod.rs')
0 files changed, 0 insertions, 0 deletions