about summary refs log tree commit diff
path: root/compiler/rustc_mir_transform/src
diff options
context:
space:
mode:
authorGuillaume Gomez <guillaume1.gomez@gmail.com>2025-07-01 17:47:05 +0200
committerGitHub <noreply@github.com>2025-07-01 17:47:05 +0200
commit8b0e7d7cc9fd74cadaf33551352ce04e52d2c06e (patch)
tree720b8d7dc8c129865b450e90f1cc9e8d972c8661 /compiler/rustc_mir_transform/src
parent61bb0764596cbf39a76b16fe0f2af5e3434813bc (diff)
parentc2daa280209b5a72a4393cee9214fc773f13c6c7 (diff)
downloadrust-8b0e7d7cc9fd74cadaf33551352ce04e52d2c06e.tar.gz
rust-8b0e7d7cc9fd74cadaf33551352ce04e52d2c06e.zip
Rollup merge of #143255 - Kobzol:disable-lld-by-default, r=jieyouxu
Do not enable LLD by default in the dist profile

History of us building & shipping LLD for `dist` builds:
1) We used to unconditionally build & ship LLD in bootstrap
2) This was causing problems for people doing custom `dist` builds (https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/MSVC.20Runtime.20mismatch.20when.20building.20LLD)
3) https://github.com/rust-lang/rust/pull/126701 made shipping of LLD optional, but to preserve previous behavior, it forcefully enabled `rust.lld = true` in the `dist` profile by default, and overwrote the default to `false` on our CI for external LLVM builds.
    - This also didn't match the documentation of `rust.lld` in `bootstrap.example.toml`, which I previously missed.
4) However, since the external LLVM opt-out was only implemented for our CI, and not for all `dist` users, this started causing issues for people `dist`ing with external LLVM (https://github.com/rust-lang/rust/issues/143076). The problem is that the default shouldn't be "true", but "LLD is enabled when LLVM isn't external", but this is not possible to do only in TOML.

So this PR reverses the behavior. LLD is not enabled by default in `dist` anymore. We switch our CI to *opt into* disting LLD, unless an external LLVM is used. External `dist` users can still opt into enabling LLD, but if they do so while also using external LLVM, they will now get a [hard error](https://github.com/rust-lang/rust/pull/143175).

r? `@jieyouxu`

try-job: `x86_64-mingw*`
try-job: dist-x86_64-linux
Diffstat (limited to 'compiler/rustc_mir_transform/src')
0 files changed, 0 insertions, 0 deletions