about summary refs log tree commit diff
path: root/compiler/rustc_parse/src/parser/diagnostics.rs
diff options
context:
space:
mode:
authorNoah Lev <camelidcamel@gmail.com>2022-02-15 19:59:04 -0800
committerNoah Lev <camelidcamel@gmail.com>2022-03-23 22:31:57 -0700
commitd915606d50c273b084bf71bff1f31e347f0ccdee (patch)
tree59f9ba2532e122d6e8b32e349242af0242056d56 /compiler/rustc_parse/src/parser/diagnostics.rs
parentc9cc43aa66911b38e9da68de6c2c7ee1f37911ea (diff)
downloadrust-d915606d50c273b084bf71bff1f31e347f0ccdee.tar.gz
rust-d915606d50c273b084bf71bff1f31e347f0ccdee.zip
Remove error recovery todos
Diffstat (limited to 'compiler/rustc_parse/src/parser/diagnostics.rs')
-rw-r--r--compiler/rustc_parse/src/parser/diagnostics.rs24
1 files changed, 9 insertions, 15 deletions
diff --git a/compiler/rustc_parse/src/parser/diagnostics.rs b/compiler/rustc_parse/src/parser/diagnostics.rs
index 99844bef1ff..b29ea808d32 100644
--- a/compiler/rustc_parse/src/parser/diagnostics.rs
+++ b/compiler/rustc_parse/src/parser/diagnostics.rs
@@ -1294,8 +1294,8 @@ impl<'a> Parser<'a> {
 
     fn prefix_inc_dec_suggest_and_recover(
         &mut self,
-        base: P<Expr>,
-        mut err: DiagnosticBuilder<'_>,
+        _base: P<Expr>,
+        mut err: DiagnosticBuilder<'a>,
         kind: IncDecRecovery,
         ident: Ident,
         (pre_span, post_span): (Span, Span),
@@ -1308,15 +1308,13 @@ impl<'a> Parser<'a> {
             ],
             Applicability::MachineApplicable,
         );
-        err.emit();
-        // TODO: recover
-        Ok(base)
+        Err(err)
     }
 
     fn postfix_inc_dec_suggest_and_recover(
         &mut self,
-        base: P<Expr>,
-        mut err: DiagnosticBuilder<'_>,
+        _base: P<Expr>,
+        mut err: DiagnosticBuilder<'a>,
         kind: IncDecRecovery,
         ident: Ident,
         (pre_span, post_span): (Span, Span),
@@ -1329,15 +1327,13 @@ impl<'a> Parser<'a> {
             ],
             Applicability::MachineApplicable,
         );
-        err.emit();
-        // TODO: recover
-        Ok(base)
+        Err(err)
     }
 
     fn inc_dec_standalone_recovery(
         &mut self,
-        base: P<Expr>,
-        mut err: DiagnosticBuilder<'_>,
+        _base: P<Expr>,
+        mut err: DiagnosticBuilder<'a>,
         kind: IncDecRecovery,
         _ident: Ident,
         (pre_span, post_span): (Span, Span),
@@ -1347,9 +1343,7 @@ impl<'a> Parser<'a> {
             vec![(pre_span, String::new()), (post_span, format!(" {}= 1", kind.op.chr()))],
             Applicability::MachineApplicable,
         );
-        err.emit();
-        // TODO: recover
-        Ok(base)
+        Err(err)
     }
 
     /// Tries to recover from associated item paths like `[T]::AssocItem` / `(T, U)::AssocItem`.