diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2023-12-28 18:48:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-28 18:48:02 +0100 |
| commit | e8831b6df892887862505d356b436d0e1ff506b0 (patch) | |
| tree | 27c97142153699881c96f3c736b173501deef6dd /compiler/rustc_parse/src/parser | |
| parent | 0b6e8f5324f84f518ec3c897abff9edb7beff0c0 (diff) | |
| parent | 7d6cd6bf1f780a7ce8487daa27eae82fd60bfcd7 (diff) | |
| download | rust-e8831b6df892887862505d356b436d0e1ff506b0.tar.gz rust-e8831b6df892887862505d356b436d0e1ff506b0.zip | |
Rollup merge of #119380 - ShE3py:match-never-pat, r=petrochenkov
Don't suggest writing a bodyless arm if the pattern can never be a never pattern #118527 enabled arms to be bodyless for never patterns ; this PR removes the `,` and `}` suggestions for patterns that could never be never patterns.
Diffstat (limited to 'compiler/rustc_parse/src/parser')
| -rw-r--r-- | compiler/rustc_parse/src/parser/expr.rs | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/compiler/rustc_parse/src/parser/expr.rs b/compiler/rustc_parse/src/parser/expr.rs index 73bd19f34c1..bf6151b64d3 100644 --- a/compiler/rustc_parse/src/parser/expr.rs +++ b/compiler/rustc_parse/src/parser/expr.rs @@ -2937,7 +2937,13 @@ impl<'a> Parser<'a> { let is_almost_fat_arrow = TokenKind::FatArrow .similar_tokens() .is_some_and(|similar_tokens| similar_tokens.contains(&this.token.kind)); - let mut result = if !is_fat_arrow && !is_almost_fat_arrow { + + // this avoids the compiler saying that a `,` or `}` was expected even though + // the pattern isn't a never pattern (and thus an arm body is required) + let armless = (!is_fat_arrow && !is_almost_fat_arrow && pat.could_be_never_pattern()) + || matches!(this.token.kind, token::Comma | token::CloseDelim(Delimiter::Brace)); + + let mut result = if armless { // A pattern without a body, allowed for never patterns. arm_body = None; this.expect_one_of(&[token::Comma], &[token::CloseDelim(Delimiter::Brace)]).map( |
