about summary refs log tree commit diff
path: root/compiler/rustc_parse/src
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2024-08-15 19:32:36 +0200
committerGitHub <noreply@github.com>2024-08-15 19:32:36 +0200
commit19e32bfc81a82ec3a54564f2da24d0c80ae8e246 (patch)
tree98b61eb269865b141375d4c75962fb097edf27f3 /compiler/rustc_parse/src
parent53bf554de82d64daecf0cf2696cf4da367a96e69 (diff)
parent478d42bdc2ba3753c9177fb4de62c0b64c806e6c (diff)
downloadrust-19e32bfc81a82ec3a54564f2da24d0c80ae8e246.tar.gz
rust-19e32bfc81a82ec3a54564f2da24d0c80ae8e246.zip
Rollup merge of #129096 - Kobzol:bootstrap-cmd-verbosity, r=onur-ozkan
Print more verbose error for commands that capture output

https://github.com/rust-lang/rust/pull/128874 made bootstrap command errors less verbose without `-v`. However, in some cases it's too extreme. If a command fails, it now outputs just `Command has failed. Rerun with -v to see more details.`, without providing any context.

I think that I found a reasonable heuristic to figure out when we should print a more verbose error. When the command doesn't capture output, its stdout/stderr is printed, therefore the user sees context about the error. However, when the command captures its output, the user won't see any error message in the output, which is not great. So only in that case, bootstrap now prints a slightly more verbose output (and also prints the captured output).

r? `@onur-ozkan`
Diffstat (limited to 'compiler/rustc_parse/src')
0 files changed, 0 insertions, 0 deletions