about summary refs log tree commit diff
path: root/compiler/rustc_parse/src
diff options
context:
space:
mode:
authorNicholas Nethercote <n.nethercote@gmail.com>2023-05-02 09:54:35 +1000
committerNicholas Nethercote <n.nethercote@gmail.com>2023-05-05 07:18:06 +1000
commitf20738dfb9b28acaa89c90bcdc6455a0dc00c4df (patch)
tree81e1de637902713b0eb40c39c91e3024305b7845 /compiler/rustc_parse/src
parent8702591e741492b282aa3b007a70716480145d1b (diff)
downloadrust-f20738dfb9b28acaa89c90bcdc6455a0dc00c4df.tar.gz
rust-f20738dfb9b28acaa89c90bcdc6455a0dc00c4df.zip
Improve filtering in `default-backtrace-ice.rs`.
This test is supposed to ensure that full backtraces are used for ICEs.
But it doesn't actually do that -- the filtering done cannot distinguish
between a full backtrace versus a short backtrace.

So this commit changes the filtering to preserve the existence of
`__rust_{begin,end}_short_backtrace` markers, which only appear in full
backtraces. This change means the test now tests what it is supposed to
test.

Also, the existing filtering included a rule that excluded any line
starting with two spaces. This was too strong because it filtered out
some parts of the error message. (This was not a showstopper). It was
also not strong enough because it didn't work with three digit stack
frame numbers, which just started seeing after upgrading my Ubuntu
distro to 23.04 machine (this *was* a showstopper).

So the commit replaces that rule with two more precise rules, one for
lines with stack frame numbers, and one for "at ..." lines.
Diffstat (limited to 'compiler/rustc_parse/src')
0 files changed, 0 insertions, 0 deletions